fix: use safe time as the default time
#3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Comparing the archive for the patched /node_modules
-atimeMs: 315532800000
+atimeMs: 456789000000
-mtimeMs: 315532800000
+mtimeMs: 456789000000
-ctimeMs: 315532800000
+ctimeMs: 456789000000
-birthtimeMs: 315532800000
+birthtimeMs: 456789000000
-atime: 1980-01-01T00:00:00.000Z
+atime: 1984-06-22T21:50:00.000Z
-mtime: 1980-01-01T00:00:00.000Z
+mtime: 1984-06-22T21:50:00.000Z
-ctime: 1980-01-01T00:00:00.000Z
+ctime: 1984-06-22T21:50:00.000Z
-birthtime: 1980-01-01T00:00:00.000Z
+birthtime: 1984-06-22T21:50:00.000Z
/node_modules/fsevents/vfs.js
-atimeMs: 315532800000
+atimeMs: 456789000000
-mtimeMs: 315532800000
+mtimeMs: 456789000000
-ctimeMs: 315532800000
+ctimeMs: 456789000000
-birthtimeMs: 315532800000
+birthtimeMs: 456789000000
-atime: 1980-01-01T00:00:00.000Z
+atime: 1984-06-22T21:50:00.000Z
-mtime: 1980-01-01T00:00:00.000Z
+mtime: 1984-06-22T21:50:00.000Z
-ctime: 1980-01-01T00:00:00.000Z
+ctime: 1984-06-22T21:50:00.000Z
-birthtime: 1980-01-01T00:00:00.000Z
+birthtime: 1984-06-22T21:50:00.000Z
-mode: 100666
+mode: 100644 |
merceyz
force-pushed
the
merceyz/fix/safe-time
branch
from
a72fade to
f86d2b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
safe timewhen writing new files and creating their parent directorycopyPromisealgorithm isn't using thesafe timechmodcalls tomodearguments #3254 fixed a bug inZipFSwherewriteFileSyncdidn't set themodeon files but didn't update the cache key causing checksum mismatches for patched packages where files are created (fsevents)How did you fix it?
Moved the
safe timetofslib, updated everything I could find to use it, and updated the cache version for the affected protocolsChecklist